[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] Issue #2291 - 'svn ls -v' should return locking information - V6

From: Alexander Thomas <kca.alexander_at_gmail.com>
Date: 2005-08-01 00:51:33 CEST

Posting version 6 of the patch for svn ls -v with locking information

Peter N. Lundblad wrote:

>But, please make the hash keys in the lock hash relative paths so they're
>the same as the keys in the dirents hash,
>
Done.

>and I suggest filtering the hash
>in the non-recursive case (so we don't return all locks under the path
>with infinite depth).
>
Not done the extra work here, I am started doing the depth parameter on
get_locks().
So hope we can live with it for a week or two.

>Also, since you're adding another parameter anyway,
>I suggest allowing it to be NULL, making it possible to avoid the possibly
>expensive get_locks call (in the non-verbose case in the cmdline client,
>for example). I think this optimization is actually a good idea, since
>else, a non-recursive, non-verbose ls command in a repository with many
>locks could be unreasonably slow.
>
>
Done.

Regards,
-Alexander Thomas (AT)

Fix issue #2291: 'svn ls -v' should return locking information.

* subversion/include/svn_client.h
  (svn_client_ls3): New prototype.
  (svn_client_ls2): Deprecated.

* subversion/libsvn_client/ls.c
  (svn_client_ls3): Gets lock information and returns it as hash.

* subversion/clients/cmdline/ls-cmd.c
  (print_dirents): Print lock information.
  (print_dirents_xml): Print lock information in xml.

* subversion/clients/cmdline/main.c
  Mention locking information in the help text for 'svn ls'.

* subversion/clients/cmdline/dtd/list.dtd
  Updated DTD file.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon Aug 1 01:21:57 2005

This is an archived mail posted to the Subversion Dev mailing list.