[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix memory leak like situation when parsing a svn_config_t object repeatedly

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2005-07-24 03:16:50 CEST

On Sun, 2005-07-24 at 02:11 +0100, Philip Martin wrote:
> Neither svn_config_enumerate nor svn_config_enumerate_sections get
> passed a pool, they use the one in svn_config_t.

Ah, I apologize; I misunderstood the situation.

> We could make the enumerate functions use a subpool, they do iterate
> after all, or we could rev the API to include a pool.

The standard workaround for having to use a baton pool instead of a
passed-in pool is to use a subpool of the baton pool, yes. Since we're
iterating here, it isn't even terribly awkward. But yes, the API should
include a pool, although it's not terribly important.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jul 24 03:19:38 2005

This is an archived mail posted to the Subversion Dev mailing list.