Re: libsvn_repos logging -- design problems

On Sat, 2005-07-16 at 01:01 +0200, Branko Čibej wrote:
> >Huh, we trust your experience on things all the time, so I dunno where
> >that "for once" comes from :-).

> Well, Greg always seems to disagree with me on issues like this one. :)

Really, I'm much more comfortable with objective arguments than "in my
experience" arguments.

The kind of logging I expect to see us introduce is not going to involve
expensive argument computations. If someone could point to a few cases
(let's say five) where we might want to do a non-trivial argument
computation for logging, then I'd be more amenable to complicating our
code for the sake of saving a few cycles. Then, I'd like to see if
other people involved in the logging discussion so far actually
envisioned that kind of logging.

> I'm all for avoiding premature optimisation, in general. In this
> particular case, a very small , low-risk investment can bring huge
> benefits in the long run.

Perhaps this argument can't be settled until we get down to the detail
level. Your initial conception of this small, low-risk investment was a
macro which used a global variable, which would have tossed out the
window different logging levels for different repositories. I'm still
not sure what this hypothetical macro would look like.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 16 01:23:13 2005