[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: issue #2264 - multiple locks over ra_svn - v4

From: VK Sameer <sameer_at_collab.net>
Date: 2005-07-07 06:33:10 CEST

On Wed, 2005-07-06 at 12:50 -0500, kfogel@collab.net wrote:
> VK Sameer <sameer@collab.net> writes:
> > > Mixture of space-before-paren and no-space-before-paren styles (in
> > > function calls, I mean). This inconsistency is going on throughout
> > > the patch, actually, but since the predominant style of the file seems
> > > to be no-space, just go with that.
> >
> > OK. I should mention, though, the patch contains the inconsistencies
> > because of copy-n-paste from other functions. I would have made changes
> > to ra_svn_(un)lock_compat(), but didn't to avoid changes not related to
> > the issue in the patch.
>
> Well, I'm not proposing that you fix space-before-paren
> inconsistencies in existing code -- as you say, that's not part of
> this change. But when you cut and paste code to a new place, then fix
> any inconsistencies in the new place!

But, of course! I didn't mean to imply it's not my responsibility, just
pointing out that there are formatting inconsistencies in the current
code. My bad in not noticing the inconsistencies in copy-pasted code in
any case.

Regards
Sameer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 7 06:38:06 2005

This is an archived mail posted to the Subversion Dev mailing list.