Re: svn commit: r15160 - trunk/tools/hook-scripts/mailer

cmpilato@tigris.org wrote:
> Author: cmpilato
> Date: Fri Jun 24 12:02:53 2005
> New Revision: 15160
>
> Modified:
> trunk/tools/hook-scripts/mailer/mailer.py
>
> Log:
> A few fixes to mailer.py. Patch by Servatius.Brandt@fujitsu-siemens.com.
>
> * tools/hook-scripts/mailer/mailer.py
> (OutputBase.make_subject): Look for 'truncate_subject' instead of
> 'truncate-subject'.

OK.

> (generate_content): Add 'show_nonmatching_paths' to the data
> dictionary.

Superficial fix, not truly fixing the bugs in this area.
If show_nonmatching_paths == 'no', then no sign that nonmatching paths
existed at all gets put in data, so "and changes in other areas" can never
appear.
And TextCommitRenderer.render tests data.show_matching_paths as a boolean,
but it's not a boolean, it's a tristate string.

> (Config._prep_maps): Postponed the removal of map section names from
> self._groups until all map specifications have been processed.

Why is this necessary, given that self._groups is never tested during
_prep_maps() ?

> (Config.get): Apply mappings on a per-word basis.

Sure, this is fine for email addresses, but is this the right thing to do
for *all* possible parameter types?
And what about compatibility?

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 24 19:47:04 2005