Re: [PATCH] check name svn special properties

Fabien COELHO <fabien@coelho.net> writes:

> Dear SVN developpers,
>
> Please find attached a patch which checks the name of svn special
> properties and refuses unexpected ones. The check are performed in the
> client library, where it seems to belong. The error can be overridden
> with --force if necessary.

Because pset already accepts --force, are you concerned that a user
passing --force for whatever other reason could also force the setting
of an invalid svn: property? I think I'm fine with that, but figured
I'd put it out there just in case.

Also, any plans to expand the patch to also cover properties set via
the auto-props functionality (used in 'svn add' and 'svn import')?

> The new feature is tested in the regression stuff. I had to remove 6
> lines of some tests which were setting invalid svn special
> properties, which are now forbidden by default.

Ah, but you didn't remove them, you commented them out. Icky.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 22 16:43:50 2005