[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: proposal: diff preview for gui client

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-06-21 09:47:17 CEST

On Mon, 20 Jun 2005, Martin Hauner wrote:

> Peter N. Lundblad wrote:
> > But, as Philip implicitly points out, that will send you text deltas
> > (which you ignore, I guess). To be more efficient, you need a revised (see
> > HACKING) version of svn_ra_do_diff, with a parameter indicating whether to
> > send text deltas or not. We already have that functionality for
> > svn_ra_do_status, so I think it should be pretty straight-forward to
> > implement.
>
> Oh, I see. So from scanning a bit through the source the big picture is:
>
> - add a new svn_ra_do_diff2 method with an additional parameter
> svn_boolean_t text_deltas
>
> - add the new boolean parameter to do_diff in svn_ra__vtable_t
>
Update the compatibility wrapper in wrapper_template.h to always pass
TRUE for this parameter.

> - and finally pass the new parameter to svn_repos_begin_report in the
> different repository access libs.
>
Update the protocols where necessary (at least for ra_svn it is).

> I guess there is some more stuff to do between the last two steps.
>
> Is this basically the correct direction?
>
>
Seems so, yes.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 21 09:48:05 2005

This is an archived mail posted to the Subversion Dev mailing list.