David James wrote:
> On 6/19/05, Max Bowsher <maxb@ukf.net> wrote:
>> The comment:
>> +# Remove any leftover test repositories
>> is a little redundant, IMO.
> Good point -- I've removed it.
>
>> Apart from that, my only complaint is that the change cleans wcs as well
>> as repositories, and should be named appropriately - just drop the
>> "-repos" part from the make rule name, and tweak the log message.
> Done. That looks much better!
>
>> Then, if it works fine for you, I think it is sufficiently localised to be
>> considered part of your commit domain, despite touching a buildsystem file.
> I was wondering about that -- thanks for the explanation! I'm glad I
> sent this patch through the list first because your feedback was very
> helpful.
You're welcome.
Regarding commit domains, there is no solid set of rules spelled out anywhere, so it's pretty much a case of following the spirit of
the law rather than the letter, because the letter of the law never got written!
We have a fairly easy-going attitude to access control in this project :-)
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 20 05:12:23 2005