[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Cleanup leftover Ruby test repositories

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-06-20 04:25:47 CEST

David James wrote:
> In some cases, the Ruby test suite leaves leftover test repositories
> and working copies lying around in your build directory. This happens,
> for example, when the test harness crashes.
>
> These leftover test repositories can cause our test suite to not work.
> They also take up disk space. So the following patch deletes the
> leftover test repositories whenever the check-swig-rb or clean-swig-rb
> targets are run.
>
> [[[
> Cleanup leftover Ruby test repositories before running the test
> suite. Also cleanup leftover Ruby test repositories as part of the
> clean-swig-rb target.
>
> * Makefile.in
> (clean-swig-rb-test-repos): Clean up leftover Ruby test repositories.
> (clean-swig-rb): Add clean-swig-rb-test-repos as dependency.
> (check-swig-rb): Add clean-swig-rb-test-repos as dependency.
>
> ]]]

The comment:
+# Remove any leftover test repositories
is a little redundant, IMO.

Apart from that, my only complaint is that the change cleans wcs as well as repositories, and should be named appropriately - just
drop the "-repos" part from the make rule name, and tweak the log message.

Then, if it works fine for you, I think it is sufficiently localised to be considered part of your commit domain, despite touching a
buildsystem file.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 20 04:26:26 2005

This is an archived mail posted to the Subversion Dev mailing list.