"Peter N. Lundblad" <peter@famlundblad.se> writes:
> > Escaping of some characters (at least '$', and '%' as the escape
> > character) is necessary. I think it is a good idea to escape the
> > space too to ease the parsing of the Id keyword (I need that here).
> > Otherwise this could be optional and could be part of bug 890.
>
> I was going to commit a patch that "fixed" this "bug". Now I realize that
> this might cause problems for people parsing the Id keyword expansion. So,
> maybe we should document Id as containing the basename of the URL, not the
> filename (I don't know if it is documented as the latter anywhere).
>
> Any opinions? Should I drop my patch or commit it?
I don't think that doing URL-escaping on the basenames in $Id$ was
ever intentional, it was just an accident of implementation.
Maybe some people who wrote code to parse the basenames are expecting
URLs (though I'll bet most haven't noticed yet), but IMHO we should
bite the bullet and treat that as "depending on a buggy behavior".
Let's just make sure to list it in the CHANGES file for the next
release -- you might want to make that part of your commit.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 16 16:34:58 2005