Re: [PATCH] Issue #869 - import should use .svn area to get props

S.Ramaswamy wrote:
> Log:
>
> Fix issue #869. Include properties when importing from a working copy.

I don't feel that this is as straightforward as it sounds. What are the
required semantics? Here is my best guess off the top of my head, but I
haven't studied the implications:

+ If a directory being imported is already a WC, then:

   + Import the directory with its existing properties (including svn:externals).

   + For each child that is versioned, import it with its existing Subversion
properties, without invoking any of the heuristic rules that would otherwise
have been used to set properties such as svn:mime-type and svn:executable.

   + Use the directory's svn:ignore property (as well as the global ignores) to
determine which unversioned files to ignore.

   + For each unversioned child to be imported, use the normal "import" rules.

Is that the behaviour we want? Is that what the patch does?

- Julian

>
> * subversion/libsvn_client/commit.c
> (import_dir) : Add properties of versioned directories.
>
> (import_file) : Add properties of versioned files.
>
> * subversion/tests/clients/cmdline/import_tests.py
> (test_list) : Added new test "import_wc" to list of import tests.
>
> (import_wc) : New test. Verify that properties are also imported.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 8 18:54:43 2005