[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] adding macro to check for a specific major/minor

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-06-05 17:37:34 CEST

Michael W Thelen wrote:
> Marcus Rueckert wrote:
>> this is a little macro i found in the apache source.
>> i used it in [1] already and it works nicely.
>> Justin Erenkrantz from the apache folks said it would be ok to use it in
>> subversion.
>>
>> [[[
>> Index: subversion/include/svn_version.h
>> ===================================================================
>> --- subversion/include/svn_version.h (revision 14707)
>> +++ subversion/include/svn_version.h (working copy)
>> @@ -238,6 +238,13 @@
>> */
>> const svn_version_t *svn_subr_version (void);
>>
>> +/* little macro borrowed from the apache source code.
>> + * Allows to check for a specific svn version.
>> + */
>> +#define SVN_VER_AT_LEAST(major,minor) \
>> + ((major) < SVN_VER_MAJOR \
>> + || ((major) == SVN_VER_MAJOR \
>> + && (minor) <= SVN_VER_MINOR))
>>
>> #ifdef __cplusplus
>> ]]]
>
> Is there any developer willing to review this patch in the next day or
> two? If not, I'll file an issue for it.

Given the nature of our compatibility policies, I'm not entirely convinced
this macro is going to be useful.

What are we going to do when we hit 2.0? Will all our numerically suffixed
symbols revert to their plain forms?
If so, then the above macro simply won't be useful to people.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jun 5 21:37:44 2005

This is an archived mail posted to the Subversion Dev mailing list.