[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn hangs in certain directories

From: Colin JN Breame <colin_at_breame.net>
Date: 2005-05-26 23:56:56 CEST

On Thursday 26 May 2005 22:14, Molle Bestefich wrote:

> I think it would be more useful for Subversion to have a progress
> counter, that would probably have shown you that it actually
> progressed with sending the file, only at a very low rate....
> If it really had hung, it would also show you that..

The problem is that it is impossible to tell from the users p.o.v. whether svn
has hung (because of a bug) or hung (because svn is waiting indefinitely for
the server to respond and there are network errors).

A timeout would be useful here; if the client does not receive any response
from the server after x seconds (when expecting a response), report an error
and fail.

Looking at libsvn_ra_svn/marshal.c readbuf_input:

/* Always block for reading. */
  if (conn->sock && conn->block_handler)
    apr_socket_timeout_set(conn->sock, -1);

According to the documentation, apr_socket_timeout_set will:

        t < 0 -- read and write calls block

I'm not sure what block_handler does (or if it is set), but it might be worth
changing this.

 -- Colin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 26 23:40:16 2005

This is an archived mail posted to the Subversion Dev mailing list.