Re: [PATCH] fix svn cat to skip unversioned items V2.

On Sat, 2005-05-21 at 03:38, Daniel Rall wrote:

> I've tested this patch and found it to work well, but am curious whether
this behavior is 1) consistent with other command-line client behavior, and
if not, 2) the type of experience that users will actually want.

The behavior is not consistent. But I would like to work on all the commands
so that they exhibit this behavior.

> Considering the case that a user makes a typo on the command-line while
casually perusing the repository, the behavior seems great. But considering
the case where the user is either gathering the contents of a few specific
files to exchange will a business partner, or scripting some operations
using the command-line client, should any of the requested files be cat'ed
when some of them cannot be?
Valid point. Should we have a command line option that tells we are
supposed to stop as soon as we get an error? Something like
stop-on-error?
I had version 1 of the patch reviewed by Peter and he thinks that other
commands should also be fixed. But considering the arguments raised by you I
would like to tackle them only if there is a consensus on the behavior.

> Vivek, a few misc. comments inline on the patch and test case:

Thanks for detailed review Dan. When I submit V3 of the patch I will try to
rectify all those mistakes.

Thanks again,
Vivek

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 23 05:16:07 2005