[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #443: post-commit hook script (error) output lost

From: Madan US <madan_at_collab.net>
Date: 2005-05-19 14:18:37 CEST

On Wed, 2005-05-18 at 01:30, kfogel@collab.net wrote:
> Madan U Sreenivasan <madan@collab.net> writes:
[...]
> > > Also does not contain a log message... :-)
> > that was intentional... didnt want to write a 200 line log message until
> > the patch is acceptable.... this was more like a review
> > submission...since the patch is loooong.... :-)
>
> I understand. But not having a log message makes a patch much harder
> to review, so please include one.
>
> Here's a way to think of it: you (1 person) can spend a bit more time
> writing a log message, or the reviewers (N people) can *each* spend a
> bit more time reviewing with the hardship of not having a log message.
> Usually, N > 1, so, in a global sense, it's "better" to write the log
> message :-).
mmmm... makes perfect sense.... I would do that. No wonder nobody has
responded yet to the patch... ;-)

thank you for explaining.

Regards,
Madan.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 19 14:25:26 2005

This is an archived mail posted to the Subversion Dev mailing list.