Branko Èibej wrote:
> Please read the HACKING file. It describes our coding style
> and patch submission guidelines (you did get those right :).
> The first problem with your patch is that the changes in the
> Python code exceed the 80-column line length limit (the
> .vcproj file doesn't have to conform to those).
Lol, at least I got one thing partially right.
I'll pay more attention to the guidelines and resubmit.
Thanks for taking the time to point things out as well.
> Another, more general comment: I think it's a mistake to set the
> BDB path in the .vcproj only if --enable-bdb-in-apr-util was
> specified. You typically use that option only the first time you
> configure the apr-util sources, but you can configure the working
> copy(that is, generate .vcproj files) more than once.
> The second time around, unmodified .vcproj files will overrwrite
> the modified ones. So I'd suggest to set the BDB path in the
> .vcprojs unconditionally.
Ok, I'll check if the APU_USE_DB/APU_USE_SDBM define is required
conditionally as well.
D.J. Heap mentioned in msg #75983 that it might not be. Infact
that post was the motivation for the modification and paying
attention to the --enable-bdb-in-apr-util in the .vcproj files.
It may be that post #75898 already contains a suitable patch
for this.
--tim--
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat May 14 17:16:26 2005