[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: SVN_ERR bypassing "goto cleanup" [was: svn commit: r14643 - ...]

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-05-11 21:00:37 CEST

Erik Huelsmann wrote:
> On 5/11/05, Julian Foad <julianfoad@btopenworld.com> wrote:
>>>- libsvn_wc/questions.c:svn_wc_text_modified_p
>>>- libsvn_wc/props.c:svn_wc_props_modified_p
>>> fails to delete a subpool
>>
>>I can't see why those functions should be using sub-pools: I can't see any
>>repetition or very large memory allocations. Can we get rid of their sub-pools?
>
> Well, if we're allocating really large chuncks of memory, we sometimes
> use subpools [...]

Do you think these functions _do_ allocate large amounts of memory?

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 11 23:31:46 2005

This is an archived mail posted to the Subversion Dev mailing list.