[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2243 - 'svn add' command not keying off svn:ignore

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-05-11 20:46:28 CEST

Julian Foad wrote:

> A quick review:
>
> S.Ramaswamy wrote:
>
>> Thanks for the review. Not sure where the new function should go -
>> libsvn_wc/status.c or elsewhere - I put it in status.c, since it has
>> similar
>> functions. Revised patch:
>
>
> Seems a bit unlikely to me that it ought to be a new, fully public
> API. I'd have thought it should be local to the command-line client,
> but I haven't thought hard about it.

On the contrary, I think it makes perfect sense to make this a public
API. We have svn_wc_get_default_ignores, and a svn_wc_get_ignores that
returns a directory-specific list is a perfect match.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 11 23:22:33 2005

This is an archived mail posted to the Subversion Dev mailing list.