SVN_ERR bypassing "goto cleanup" [was: svn commit: r14643 - ...]

[Making this thread more visible and following up.]

Philip Martin wrote:
> I decided to have a look at our existing uses of "goto cleanup", just
> to see how many had SVN_ERRs that bypassed the cleanup.
>
> These look like real errors:
>
> - libsvn_wc/adm_crawler.c:svn_wc_crawl_revisions2
> fails to call reporter->abort_report
>
> - libsvn_ra_dav/util.c:parsed_request
> fails to destroy neon structures
>
> - libsvn_fs_base/fs.c:base_create
> - libsvn_fs_base/fs.c:base_open
> fails to call cleanup_fs
>
> - libsvn_client/commit.c:svn_client_commit
> fails to call editor->abort_edit

Philip fixed those in r14667.

> Leaving a subpool isn't really a problem, so these are not bugs:
>
> - libsvn_wc/questions.c:svn_wc_text_modified_p
> - libsvn_wc/props.c:svn_wc_props_modified_p
> fails to delete a subpool

I can't see why those functions should be using sub-pools: I can't see any
repetition or very large memory allocations. Can we get rid of their sub-pools?

> I don't understand the significance of this one:
>
> - libsvn_wc/status.c:close_edit
> fails to clear traversal_info

I haven't looked because I'm pretty sure I won't understand either.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 11 17:44:54 2005