[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14482 - in trunk/subversion: mod_dav_svn

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-05-10 15:13:08 CEST

Ben Collins-Sussman wrote:
> On May 10, 2005, at 6:55 AM, Julian Foad wrote:
>>>> Author: sussman
>>>> Date: Wed Apr 27 14:42:27 2005
>>>> New Revision: 14482

[...]

>>>> * subversion/mod_dav_svn/lock.c (svn_lock_to_dav_lock): divide
>>>> 64-bit int by 1000 before casting to 32-bit.
>>>> (dav_lock_to_svn_lock): cast to 64-bit int before mulitplying by
>>>> 1000.
>>
>> Since when have there been 1000 microseconds in a second?
>
> What the heck? We should be using APR_USEC_PER_SEC, right? I thought
> it was 'milli' for some reason. Is this a big bug?

The only bug is in the commit log message. The code is correctly using
"APR_USEC_PER_SEC".

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 10 15:14:14 2005

This is an archived mail posted to the Subversion Dev mailing list.