Re: [PATCH]: Re: svn status -u crash w/ moved external

kfogel@collab.net writes:

> "C. Michael Pilato" <cmpilato@collab.net> writes:
>
>> and, what's more, would prefer
>> that the code also explicitly check for the SEGFAULT cause -- that
>> parent_status->entry is NULL.
>
> I'd rather not do that; we could cover up a lot of bugs that way.
>
> Basically, we have every right to expect that parent_status->entry
> exists *unless* one of several possible unversioned scenarios is true.
> We should check for those scenarios, but not cover up the problem if
> parent_status->entry is unexpectedly NULL.

I remember Steve King reporting some TSVN crashes where the immediate
cause was something like parent_status->entry being NULL, but when we
looked at the code we could not determine how it could happen. I
never considered svn:externals.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org