Re: [PATCH] 'svn blame --xml' and fix for mutliple targets for svn blame

On Fri, 2005-04-29 at 15:17 +0200, Peter N. Lundblad wrote:

> > @@ -70,18 +131,57 @@

> I think making the element optional is better than having an empty
> string (again, see below).
>
> > + author ? author : " -",
> > + time_stdout,
>
> This strings with padding spaces makes sense in the traditional blame
> output, but not in XML, which is a structured format.
>
I agree, why not author and date to be made optional?

> I think the XML output should output all information available and
> ignore the -v flag. That's what the list command does. The output will
> be parsed by a machine anyway.
 I don't vote for this, my suggestion is to keep both the options (-v
and without -v) intact.

> Very minor and a matter of taste, but here you spoil five lines where
> two would do.
> if (opt_state->xml && ! opt_state->incremental)

thanks

-Alexander Thomas (AT)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 29 15:44:22 2005