Re: locking a file renders repos unusable with older clients

On Mar 28, 2005, at 5:07 PM, C. Michael Pilato wrote:
>
> Question: How much do we care about repository sanity during this
> upgrade? I started to code these new APIs, but couldn't decide if I
> needed to reproduce the whole 'exclusive lock' code ala
> svn_repos_recover2(), and, if so, how to deal with the same scenario
> down in the svn_fs libraries (which, in theory, could be upgraded
> independently of the svn_repos wrapper).
>
>

I think that svn_repos_upgrade() should share the same "waiting for
exclusive repository lock" logic that svn_repos_recover() uses.

In both cases, the repos-locking mechanism isn't perfect; some
libsvn_fs program could be running and completely ignoring the
repos-lock. But in general, people use 'good citizen' programs which
use libsvn_repos. This doesn't seem to be a real risk.

As long as you document svn_fs_upgrade_blah() with something like
"Warning: process should have exclusive access to filesystem when
running this", then I think we're fine.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 29 20:38:59 2005