Re: svn commit: r13631 - in trunk/subversion: include libsvn_fs libsvn_fs_base libsvn_fs_fs libsvn_ra_local libsvn_repos mod_dav_svn svnserve tests/libsvn_fs tests/libsvn_repos

On Thu, 24 Mar 2005, C. Michael Pilato wrote:

> "Peter N. Lundblad" <peter@famlundblad.se> writes:
>
> > > @@ -1516,48 +1524,12 @@
> > > svn_error_t *svn_fs_lock (svn_lock_t **lock,
> > > svn_fs_t *fs,
> > > const char *path,
> > > + const char *token,
> > > const char *comment,
> > > - svn_boolean_t force,
> > > long int timeout,
> >
> > That's not an apr_time_t as the log says. (I'd support that change,
> > though.)
>
> My fault. I started to make it an apr_time_t, then bailed (but forgot
> to tweak the log). My reasoning was that an apr_time_t is supposed to
> represent a moment in Time, not a span thereof. I dunno. I'd not -1
> a change to apr_time_t if the community wants it.
>
Of course it was your fault:-) Seriously, there is an apr_interval_time_t,
which we could use. But... well... I don't care much about it. subsecond
granularity for this seems like enormous overkill... But if someone wants
to feela little more pedantic...

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 29 09:48:32 2005