[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ra_dav tests failing

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-03-27 21:23:01 CEST

Ben Collins-Sussman <sussman@collab.net> writes:

>> Ben Collins-Sussman <sussman@collab.net> writes:
>>
>>> 1. How do we find all paths in the lock-token hash which are children
>>> of the directory? There's no magical partial-key lookup here, like we
>>> have in BDB.

> mod_dav_svn already understands how to make use of per-request tokens,
> and this is necessary for interoperability with DAV clients. But
> instead of sending all the tokens in the final MERGE request's body,
> why not mimic the other RA layers and push *all* the tokens into the
> filesystem as part of the initial MKACTIVITY request?
>
> If we did this, then none of the other svn-generated commit requests
> would have to send tokens at all. Let the generic DAV clients do
> that, we wouldn't need to.
>
> Doesn't this seem a lot more elegant?

At first I wondered how this helped with the question "how do we find
all paths in the lock-token hash which are children of the directory"?
I wondered why your proposal didn't simply move the problem to
mod_dav_svn, and why mod_dav_svn should do it any better than ra_dav?
Then I realised that mod_dav_svn uses the existing fs structure to get
children of the directory, it doesn't have to search all the locks
looking for children. So I guess the answer to your original question
is that the ra_dav library could use a wc callback to identify the
children of the directory.

I know next to nothing about DAV, but your activity proposal sounds
more elegant than the wc callback.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Mar 27 21:24:16 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.