[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

svnadmin cleanup

From: Marcus Rueckert <darix_at_web.de>
Date: 2005-03-25 06:32:23 CET

hi

while reading through the source of svn and poking around within the
source i got some questions.

1. svnadmin create has --config-dir parameter. i asked fitz what
settings from the config might influence the repos creation. reading
through the source of svnadmin leads me to svn_repos_create() in
repos.c. the config object is passed to the function but not used there.
only fs_config is used. but that is pass in another param.

this seems to be some old unused code. would it harm to pass NULL to
svn_repos_create()?

2. while reading main.c of svnadmin i saw this
[[[
#include "svn_private_config.h" /* for SVN_TEMPLATE_ROOT_DIR */
]]]

SVN_TEMPLATE_ROOT_DIR doesnt exist in my svn_private_config.h*

i think this include can be removed.

now back to the code.

darix

-- 
irssi - the client of the smart and beautiful people
              http://www.irssi.de/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 25 06:34:27 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.