Re: Feature proposal: maintain timestamps on svn hotcopy

On Wed, 23 Mar 2005 23:00:27 +0000, Philip Martin
<philip@codematters.co.uk> wrote:

> You can't add a parameter to svn_io_copy_file as that would break the
> ABI. You need to rename the function, to svn_io_copy_file2 say, add
> the new parameter and implementation, and then write a wrapper with
> the original name and parameter list that calls the new function.

Oh, crud. I spent the afternoon adding the parameter to svn_io_copy_file
and trickling it upwards to all the callers -- a good twelve or so files were
changed. Good thing I asked. :)

Anyways, I'm still going to have to modify other stuff in io.c... what can
and can't I modify without breaking the ABI? Is there a rule of thumb I
can follow to make sure I don't screw things up for everyone else?
(My apologies for being a total n00b on this.)

> I don't think there is a specific test for svn_io_copy_file but the
> regression tests as whole exercise it. The hotcopy command gets run
> by subversion/tests/clients/cmdline/svnadmin_tests.py, you might like
> to add to that.

Cool.

--sgp

-- 
scott parkerson. geek, erstwhile prophet and fool.
just a cog in the machinery: http://www.smerpology.org/sprocket/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org