On Wed, 2005-03-23 at 15:33 +0000, Julian Foad wrote:
> Daniel Berlin wrote:
> > On Tue, 2005-03-22 at 10:39 +0000, Max Bowsher wrote:
> >>Why does the ipv6_supported variable exist at all in the below code?
> [...]
> >>Couldn't it be removed entirely with *NO* change to the functioning of the
> >>code at all, like so:
> >
> > I can't think of a compiler that won't do this on it's own, but feel
> > free :)
>
> It's the tiny bit of extra source code that's the concern from a
> maintainability point of view, more than the run-time efficiency.
>
> Is this patch OK?
>
> [[[
> Simplify some source code.
>
> * subversion/libsvn_ra_svn/client.c (make_connection):
> * subversion/svnserve/main.c (main):
> Simplify the IPv6 detection code slightly, removing a variable.
> ]]]
>
> - Julian
Looks right.
You should probably run it through svncheck6 just for kicks (assuming
you have ipv6 support in your OS)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 23 16:47:42 2005