[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_wc_get_switch_editor() and svn_wc_get_update_editor() have some memory bugs

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-03-21 22:55:06 CET

On Tue, 22 Mar 2005, Kouhei Sutou wrote:

> svn_wc_get_switch_editor() and svn_wc_get_update_editor()
> doesn't allocate a memory for svn_wc__compat_notify_baton_t
> although it's needed.
>
Wholy cow! Thanks for detecting this!

> ---
> Allocate a memory for svn_wc__compat_notify_baton_t which is
Change "a memory" to just "memory".

> not temporally used.
temporarily.
>
> * subversion/libsvn_wc/update_editor.c
> (svn_wc_get_update_editor)
> (svn_wc_get_switch_editor): Allocate a memory.
"a memory" -> "memory"

+1. Please commit!

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 22 00:37:39 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.