Re: svn commit: r13393 - in branches/locking/subversion: include libsvn_client libsvn_wc

lundblad@tigris.org writes:

> Author: lundblad
> Date: Sat Mar 12 19:14:11 2005
> New Revision: 13393

> +/* Implements svn_ra_reporter2_t->link_path. */
> +static svn_error_t *
> +reporter_link_path (void *report_baton, const char *path, const char *url,
> + svn_revnum_t revision, svn_boolean_t start_empty,
> + const char *lock_token, apr_pool_t *pool)
> +{
> + report_baton_t *rb = report_baton;
> + const char *ancestor;
> + apr_size_t len;
> +
> + /* Get the common ancestor of the URL and our current ancestor. */

That comment doesn't add much.

> + ancestor = svn_path_get_longest_ancestor (url, rb->ancestor, pool);
> +
> + /* If we got a shorter ancestor, truncate our current ancestor. */

That comment tells me what is happening, but not why.

> + len = strlen (ancestor);
> + if (len < strlen (rb->ancestor))
> + rb->ancestor[len] = '\0';

I find that a bit confusing, I suppose the main aim is to to ensure
that rb->ancestor is allocated from a pool with a correct lifetime,
but I don't understand why you don't simply pass rb->pool into
svn_path_get_longest_ancestor. Is rb->pool the wrong pool? Is the
memory saved by reusing rb->ancestor important?

> +
> + return rb->wrapped_reporter->link_path (rb->wrapped_report_baton, path, url,
> + revision, start_empty, lock_token,
> + pool);
> +}
> +

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org