Brian W. Fitzpatrick wrote:
>
> On Mar 14, 2005, at 2:06 PM, Garrett Rooney wrote:
>
>> Ben Collins-Sussman wrote:
>>
>>> Given that svn_repos_fs_(un)lock() will probably -- eventually -- be
>>> receiving a whole list of locks from the network, cmpilato and I are
>>> wondering if it makes sense to define the post-(un)lock hooks as
>>> taking a list of paths *right now*, rather than one path. If
>>> somebody decides to lock 5000 things at once, it's important to get
>>> one email, not 5000 of them.
>>
>>
>> Make sure to pass the list via STDIN or something, rather than ARGV,
>> you don't want to hit arbitrary limits on the number of arguments that
>> can be passed to a program.
>
>
> Good point. I'm going to get started on revising the post-(un)lock
> hooks to read locked paths from STDIN. I figure that it will be safe to
> separate each path by a newline.
Yeah, we're already assuming paths can't have newlines in them in other
places (dumpfile format, for example), so it's not like it can really
hurt to do it here.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 15 01:26:20 2005