[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2219 - Canonicalize values in svn:keywords - v3

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2005-03-10 05:03:22 CET

On Wed, 2005-03-09 at 18:38, John Peacock wrote:
> Madan U Sreenivasan wrote:
> > * subversion/libsvn_wc/props.c
> > (svn_canonicalize_keywords): New function to
>
>
> Internal/private functions don't have "svn_" prefix in their name. Maybe I'm
> just misreading the tests, but I don't see a place where you attempt to set two
> different aliases in svn:keyword and show that only a single canonical entry
> results.
>
Oh, sorry, I didnt notice that convention... would remove the svn_
Reg the test case, Pl. look at the following
  given_input = [
                      ...
                     "lastchangedrevision author LastChangedBy"
                      ...
                    ]
This would yeild 'Revision Author Author', but the actual output is
'Revision Author', which is checked against in the expected_output
array.
> Other than that, this looks great to me (I'm running the test suite now)!
>
> John
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 10 04:57:14 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.