Re: svn commit: r13300 - trunk/subversion/libsvn_fs_base

Justin Erenkrantz <justin@erenkrantz.com> writes:

>> ===== --- trunk/subversion/libsvn_fs_base/tree.c (original)
>> +++ trunk/subversion/libsvn_fs_base/tree.c Mon Mar 7 19:27:45 2005
> ...snip...
>> @@ -2394,6 +2396,7 @@
>> * it.
>> */
>>
>> + svn_pool_destroy (subpool);
>> return SVN_NO_ERROR;
>> }
>>
>
> Sun's compiler complains that this section is unreachable. Based on
> my examination, I think that's right: it's not possible to ever exit
> that while loop any more. So, any reason to keep these two lines?
> I'll replace it with a /* NOTREACHABLE */ comment... -- justin

I looked at the code and could not see the problem, then I realised
you had probably shown the wrong bit of code. Did you mean line 2697?
If so then this is probably better as it causes pool destruction (but
I haven't compiled or tested it):

Index: subversion/libsvn_fs_base/tree.c
===================================================================
--- subversion/libsvn_fs_base/tree.c (revision 13315)
+++ subversion/libsvn_fs_base/tree.c (working copy)
@@ -2690,7 +2690,7 @@
         {
           /* Set the return value -- our brand spankin' new revision! */
           *new_rev = commit_args.new_rev;
- return SVN_NO_ERROR;
+ break;
         }
     }
 

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org