[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_client_propget target param problem?

From: Barry Scott <barry_at_barrys-emacs.org>
Date: 2005-03-06 23:00:57 CET

O.k. do you need a bug logged?

Barry

On Mar 6, 2005, at 21:22, Philip Martin wrote:

> Philip Martin <philip@codematters.co.uk> writes:
>
>>>> Am I right in thinking that this is bug in the implementation of
>>>> svn_client_propget?
>>>
>>> Yes.
>>>
>>>> Shouldn't the key be allocated out of the pool I pass in?
>>>
>>> It should, see the documentation in svn_client.h.
>>
>> There is another bug as well: the documentation states that the
>> key/value pair should only be stored if the property is set but the
>> code appears to store them unconditionally.
>
> It get worse: the propget_walk_cb callback does a schedule check that
> is not present in the non-recursive code. Since svn_wc_walk_entries2
> handles files as targets the non-recursive code should probably be
> dropped.
>
> --
> Philip Martin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Mar 6 23:02:19 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.