[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Code review requested.

From: Brian W. Fitzpatrick <fitz_at_collab.net>
Date: 2005-03-03 01:30:47 CET

On Mar 2, 2005, at 5:43 PM, Philip Martin wrote:

> "Brian W. Fitzpatrick" <fitz@collab.net> writes:
>
>> On Wed, 2005-03-02 at 19:01 +0000, Philip Martin wrote:
>>> Philip Martin <philip@codematters.co.uk> writes:
>>>
>>>> Looks like at least one of your subpool changes is wrong:
>>>>
>>>> $ subversion/tests/libsvn_fs_base/fs-test 23
>>>> Segmentation fault
>>>
>>> I've just confirmed that reverting r13208 makes this crash go away.
>>
>> I'm unable to reproduce as of r13225 on trunk:
>>
>> $ ./subversion/tests/libsvn_fs_base/fs-test 23
>> PASS: lt-fs-test 23: merging commit
>
> The bug involves using pool memory after the pool has been cleared, do
> you have APR's pool debugging enabled? It's normal for these bugs not
> to show up unless you have pool debugging enabled, mainly because our
> test cases are small, single threaded and don't use much memory. That
> doesn't make the problem less serious, using pool memory after the
> pool has been freed is always a bug.

Ah. Thanks for the clarification. I'll try enabling pool debugging
later tonight and take a peek.

-Fitz

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 3 01:32:05 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.