[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]Issue #2219 - svn:keywords canonicalization

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-03-01 16:04:19 CET

John Peacock wrote:
> Madan U Sreenivasan wrote:
>> I would like to clarify... is the following behavior what is expected?
>>
>> $ svn ps svn:keywords lastchangedby file.c
>> $ svn pg svn:keywords file.c
>> LastChangedBy
>> $
>
> Exactly (at least that's what _I_ expect). In fact, I would go one step
> farther:
> $ svn ps svn:keywords AuThOr file.c
> $ svn pg svn:keywords file.c
> LastChangedBy
>
> In other words, accept any capitalization of any of the aliases for a
> given
> keyword, but only store the LONG name in the property. And document this
> thoroughly; it is still suprising for some people that you can set the
> svn:keywords value to Revision and both $Rev$ and $LastChangedRevision$
> both
> expand. Any patch to document this behavior is a Good Thing(tm)!

Wait a sec!

I hugely dislike the proposal to canonicalize to the LastChangedFoo form.

The LastChanged bit is extra explanatory verbiage which might help to
explain the value to random audience browsing the file, without any
knowledge of keywords, but is unnecessary and makes the important
information in svn:keywords less visible.

I think we should canonicalize towards:

HeadURL
Author
Revision
Date
Id

> The idea is that we cannot fix the existing svn:keywords values (until a
> dump/reload cycle, say for 1.2.0)

We can't have a mandatory dump/load until 2.0.0.

> but we want to make sure all new keywords
> come from the much smaller universe of defined long names.

Defined *canonical* names... which doesn't necessarily equal "long".

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 1 16:06:47 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.