[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12859 - trunk/subversion/clients/cmdline

From: <kfogel_at_collab.net>
Date: 2005-01-31 23:13:28 CET

julianfoad@tigris.org writes:
> Log:
> Fix the encoding of XML output from "svn list --xml": output it as UTF-8.
>
> * subversion/clients/cmdline/log-cmd.c
> (error_checked_fputs): Extracted and made semi-public with svn_cl__ prefix.
> (log_message_receiver_xml, svn_cl__log): Adjust calls accordingly.
>
> * subversion/clients/cmdline/cl.h
> * subversion/clients/cmdline/util.c
> (svn_cl__error_checked_fputs): New; was log-cmd.c::error_checked_fputs.
>
> * subversion/clients/cmdline/ls-cmd.c
> (print_header_xml, print_footer_xml): New helper functions, for tidiness.
> (print_dirents_xml, svn_cl__ls): Avoid converting UTF-8 to native encoding
> when writing XML output.
>
>
> Modified: trunk/subversion/clients/cmdline/cl.h
> Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/clients/cmdline/cl.h?view=diff&rev=12859&p1=trunk/subversion/clients/cmdline/cl.h&r1=12858&p2=trunk/subversion/clients/cmdline/cl.h&r2=12859
> ==============================================================================
> --- trunk/subversion/clients/cmdline/cl.h (original)
> +++ trunk/subversion/clients/cmdline/cl.h Wed Jan 26 12:30:52 2005
> @@ -434,6 +434,10 @@
> /* Add a message about --force if appropriate */
> svn_error_t *svn_cl__may_need_force (svn_error_t *err);
>
> +/* Write the STRING to the stdio STREAM, returning an error if it fails. */
> +svn_error_t *svn_cl__error_checked_fputs (const char *string,
> + FILE* stream);
> +

We usually write "FILE *stream", w/ space before star instead of after.

Didn't see anything suspicious in the rest of the commit. Thanks for
doing this!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jan 31 23:25:27 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.