[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Crash in svn_client_ls()

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-01-26 21:11:46 CET

SteveKing <steveking@gmx.ch> writes:

> Philip Martin wrote:
>> SteveKing <steveking@gmx.ch> writes:
>>
>>>when calling svn_client_ls() with path_or_url param as an empty string
>>>(I know, that's a bug in TSVN) then a crash occurs. Since it's wrong
>>>to pass an empty path to that function it's not that important, but
>>>still, I think Subversion shouldn't crash but return an error.
>>
>> When you say 'empty string' do you mean "" or do you mean NULL?
>> Passing "" (which Subversion refers to as an empty string) should
>> work. NULL is an error by the caller, and Subversion doesn't
>> generally attempt to catch such errors. If you feel that it should
>> catch NULL then I think you will find that most of the Subversion
>> developers disagree.
>
> I mean an empty string (""), not NULL.

I don't think the path is the problem. I don't have a 1.1.3 binary,
but neither 1.1.1 and HEAD have any problem with 'svn ls ""' and that
passes "". I think it's more likely to be some strange URL associated
with the directory.

Your stack showed ra_dav/props.c:648, it appears that ne_uri_parse has
returned a NULL path. It looks like a Subversion bug as it doesn't
check the return status of ne_uri_parse, which can fail and return -1.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 26 21:13:14 2005

This is an archived mail posted to the Subversion Dev mailing list.