[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Locking] Repos reporter and locks

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2005-01-25 05:37:33 CET

On Jan 24, 2005, at 4:19 PM, Peter N. Lundblad wrote:

> Hi,
>
> I am currently revving the libsvn_repos reporter that gets a report
> about
> WC revisions and sends back a tree delta. For locking, it needs to
> store
> lock tokens and from the client and senc back lock token removes for
> defunct locks (for svn up) or just report all locks in the repository
> (for
> svn st).
>
> My main problem is the latter case. I really don't like the idea of
> using
> svn_fs_get_locks for the anchor of the report and pull all the locks of
> the repository into the server memory at once.

I'm not sure I understand; it sounds like you're objecting to the
svn_fs_get_locks API itself. You don't like the fact that it returns
an "all in memory at once" hash of locks?

If you think that such a thing is non-scalable, then perhaps we should
change that particular API. Instead of returning a hash, perhaps it
could call a callback for each lock. (I definitely don't want to stat
every fs path for a lock!)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 25 05:39:50 2005

This is an archived mail posted to the Subversion Dev mailing list.