[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: "make install-swig-{pl,py}" implies "make install" for some libraries (Issue 2126)

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-01-21 22:49:57 CET

Ben Collins-Sussman wrote:
> In my mind, there's a clear dependency between the 'install-swig-pl'
> and 'install' targets. You cannot install functional bindings unless
> core svn libraries are installed first.
>
> By denying this dependency, I think we'd be making our build system
> inconvenient for the majority of users; I think the majority of people
> install *all* of subversion (binaries, libs, and bindings) as a single
> user, and often all at once. It would be unfriendly for 'make
> install-swig-pl' to throw an error about missing svn libraries (or
> worse, silently installing non-functional bindings!)
>
> Maybe a better compromise is to make a new target that *only* installs
> bindings, and has no dependencies?

I find myself disagreeing.

If I run "make install-some-additional-feature", I expect
"some-additional-feature" to be installed. I don't expect
"some-additional-feature", and some _subset_ of the base package to be
installed.

Note especially, if I run "make install-swig-py" in isolation, it seems
reasonable that I want to add bindings to an existing installation, and
currently if I run "make install && make install-swig-py", certain
components are installed by both make invocations!

To make it easy for the people who just install everything, I think we
should fix --enable-swig-bindings to included explicitly enabled bindings
install targets within "make install".

Responding specifically to your point about friendliness of "make
install-swig-pl":
If the user is running "make install-swig-pl" straight after "make install",
then they will have the libs installed anyway. If they are running it in
isolation, then the install should not reach out and touch the libraries -
either they are already compatible, and don't need to be overwritten, or the
user is doing something wrong, and changing the libraries could break
installed command line tools.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 21 22:53:08 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.