[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Limit size of emails sent using commit-email.pl

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-01-19 22:04:29 CET

kfogel@collab.net writes:

> VK Sameer <sameer@collab.net> writes:
> > OK, removed the max diff size variable. I just wasn't sure if there
> > could be a situation where non-diff content could be large as well.
> >
> > Regards
> > Sameer
> > Add variable to control email message size based on email body size
> >
> > * commit-email.pl.in
> > $max_email_body_size: New variable
> > check_truncate(): New function to truncate an array of strings
> > Added call to check (and possibly truncate) size of @body
>
> Did you consider a solution in which instead of truncating a large
> diff, we just replace it with the appropriate ViewCVS diff URL?
>
> I think showing half a diff is not very useful. Better to simply not
> show it at all, and instead give a pointer to get the diff online.

We didn't integrate ViewCVS support into mailer.py because we didn't
want to get into the game of endorsing particular repository browser
programs. We won't do so for commit-email.pl either.

Further, having already *done* this very commit-email.pl/ViewCVS
integration myself (for CollabNet), let me assure you that we *DO NOT*
want Sameer (or anyone) wasting time on such a painful (and
not-fully-solvable) problem. svnlook simply doesn't yield enough
information to get this right.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 19 22:10:58 2005

This is an archived mail posted to the Subversion Dev mailing list.