Re: Enforce canonical paths in client-server protocol?

Julian Foad <julianfoad@btopenworld.com> writes:

> As for the implementation quality of "is_canonical", it should be
> equivalent to "canonicalize". It could just call "canonicalize" and
> see if the result is any different.

When I wrote "is_canonical" it matched "canonicalize", although since
then "canonicalize" has been changed. As originally written
"is_canonical" is extremely efficient so I called it from lots of
places as a debugging aid. Making "is_canonical" match the current
"canonicalize" will make it less efficient, I don't know whether it
would be appropriate to call it as frequently. grep for "Expensive
strlen" to find those places where the current version could not be
called efficiently.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org