[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12683 - branches/locking/subversion/libsvn_fs_fs

From: Brian W. Fitzpatrick <fitz_at_collab.net>
Date: 2005-01-13 00:08:56 CET

On Wed, 2005-01-12 at 16:28, Philip Martin wrote:
> fitz@tigris.org writes:
>
> > Author: fitz
> > Date: Wed Jan 12 13:18:44 2005
> > New Revision: 12683
>
> > --- branches/locking/subversion/libsvn_fs_fs/lock.c (original)
> > +++ branches/locking/subversion/libsvn_fs_fs/lock.c Wed Jan 12 13:18:44 2005
>
> > + err = svn_io_file_read_full (fd, buf, nbytes, &nbytes, pool);
> > +
> > + if (err && APR_STATUS_IS_EOF (err->apr_err))
> > {
> > - apr_file_close(fd);
> > - return svn_error_wrap_apr (status,
> > - _("Error reading lock entries file '%s.'"),
> > - path);
> > + svn_error_clear (err);
> > + break;
> > + }
> > + if (err)
> > + {
> > + SVN_ERR (svn_io_file_close (fd, pool));
>
> If svn_io_file_close fails then err leaks.

So just call svn_error_clear before svn_io_file_close?

-Fitz

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jan 13 00:10:26 2005

This is an archived mail posted to the Subversion Dev mailing list.