[PATCH]: svn commit: r12615 - in javahl: `ltoa' undeclared

When I integrated bindings testing to the svntest framework, I found
following:

/srv/svntest/svntest/obj-sh/../svn/svn_trunk/subversion/bindings/java/javahl/native/SVNClient.cpp:2758:
error: `ltoa' undeclared (first use this function)

On 2005-01-06 13:18-0600, pmayweg@tigris.org wrote:
> ..
> + std::string value = ltoa(sb.min_rev, JNIUtil::getFormatBuffer(), 10);
> + if (sb.min_rev != sb.max_rev)
> + {
> + value + ":";
> + value += ltoa(sb.max_rev, JNIUtil::getFormatBuffer(), 10);
> + }
> ...

ltoa isn't defined here, and I could not find it from anywhere on my system
(gcc (GCC) 3.4.3 ).

The following patch fixes javahl, and make it more C++ like, any
objection to commit this?

BR, Jani

Log:
Don't use ltoa for number to string conversion, it isn't defined
everywhere and it isn't very C++. Use ostringstream instead.

* subversion/bindings/java/javahl/native/SVNClient.cpp
  (SVNClient::getVersionInfo): Use ostringstream instead of ltoa.

-- 
Jani Averbach                 jaa@iki.fi              +1-303-415-0199 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org