Re: svn commit: r12564 - in branches/locking/subversion: clients/cmdline libsvn_wc

lundblad@tigris.org writes:

> Author: lundblad
> Date: Sun Jan 2 11:20:54 2005
> New Revision: 12564
>
> Modified:
> branches/locking/subversion/clients/cmdline/status.c
> branches/locking/subversion/libsvn_wc/status.c
> Log:
> Locking branch: Add lock token indication for tokens in the WC to svn status
> output.
>
> * subversion/libsvn_wc/status.c (assemble_status, is_sendable_status): Conside
> entries with lock tokens interesting.
> * subversion/clients/cmdline/status.c (print_status): Print a K in the sixth
> column if the WC has a locK toKen for the entry.

> SVN_ERR
> (svn_cmdline_printf (pool,
> - "%c%c%c%c%c %c %6s %6s %-12s %s\n",
> + "%c%c%c%c%c%c %c %6s %6s %-12s %s\n",

Is that allowed? It might break anything that is parsing the current
output, and the compatability rules in HACKING don't explicitly
mention changes like this. Is the status output part of the API?

Until directory locking is available the current 'L' and new 'K' can
never apply to the same item, so they could use the same column. In
the short term that might be less likely to break parsers, but in the
long term, if/when directory locking does appear the 'K' would have to
move. I don't know whether that is better or worse.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org