[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [BUG] svn commit ignores --non-interactive

From: Oliver Klozoff <stevieoh_at_fastmail.fm>
Date: 2004-12-22 21:16:13 CET

> As I alluded to in my previous message, if you do that,
> you'll break my script. It runs from a GUI process (where it
> cannot do interactive prompting since stdin isn't a TTY). It
> works because --editor-cmd causes a GUI text editor to edit
> the log message - the problem is in what happens when the
> user (me) inadvertently leaves the message blank (for
> example, by fat fingering the keyboard and closing the editor
> window.)

Okay, now I understand your problem.

The only way I can think of to *correctly* solve this problem is to add a
field to svn_client_ctx_t that contains the 'non-interactive' flag, and then
have svn_cl__get_log_message (in util.c) check this flag before asking for a
prompt.

We *could* solve the problem more locally by adding placing the flag in the
log_msg_baton function, but the problem with that is, we have to change
something else if something *elsewhere* decides to start prompting.

An alternative would be to not prompt the user under any circumstances, and
if they want to commit a blank log message, they have to use -m '' (or
perhaps --force-log).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 22 21:18:54 2004

This is an archived mail posted to the Subversion Dev mailing list.