RE: [PATCH] Python mailer hook script for Windows (2nd attempt)

>Actually, I'd just forbid piping to any kind of sendmail program on
Windows. You don't need it, since you can use Python's mail class and
use SMTP (even if you do use some kind of sendmail clone, you can SMTP
to localhost).
>
That fine with me. I was just adding it to be compatible with Unix.

>Looking at the patch below, the number of "if ...win32" tests gives me
the shudders.
-1, all those conditionals can be avoided if you use an OS-specific
helper class.
>
Can you give a small example of what you are looking for?

>Wha's that comma doing in the regular expression pattern? Why would you
quote parameters that contain a comma?
>
Hmm, you are right. It doesn't belong in there. I think I was thinking that I had to separate the characters by commas.
Received on Wed Dec 22 13:49:16 2004