[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r12489 - trunk/subversion/libsvn_wc

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2004-12-22 00:19:25 CET

breser@tigris.org writes:

> Author: breser
> Date: Tue Dec 21 16:47:58 2004
> New Revision: 12489
>
> Modified:
> trunk/subversion/libsvn_wc/lock.c
> Log:
> Fix the confusing error message in Issue #2174

> --- trunk/subversion/libsvn_wc/lock.c (original)
> +++ trunk/subversion/libsvn_wc/lock.c Tue Dec 21 16:47:58 2004
> @@ -640,7 +640,7 @@
> for NULL batons. */
> if (! *adm_access)
> return svn_error_createf (SVN_ERR_WC_NOT_LOCKED, NULL,
> - _("Working copy '%s' not locked"),
> + _("Working copy '%s' is missing or not locked"),

That might help users but it has the potential to cause developer
confusion. The locking code already uses "missing" to refer to a
different concept, see svn_wc__adm_missing, and a directory that
generates SVN_ERR_WC_NOT_LOCKED is not "missing" in that sense.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 22 00:20:34 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.