[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: IS_FNCHAR ok to use?

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2004-12-14 10:19:24 CET

On Tue, 14 Dec 2004, VK Sameer wrote:

> On Tue, 2004-12-14 at 13:55, Peter N. Lundblad wrote:
> > On Tue, 14 Dec 2004, VK Sameer wrote:
> >
> > I'm not sure I think that's a good idea.
>
> Using IS_FNCHAR or os-specific checks altogether?
>
OS-specific checks.

> > When would you do this check?
>
> It would be part of a check for os-specific characters before creating
> and adding a file in a working copy.
>
> These are the files:
> subversion/libsvn_wc/copy.c
> subversion/libsvn_wc/adm_ops.c
> subversion/libsvn_wc/update_editor.c
> subversion/libsvn_client/copy.c
>
Wouldn't that be rather useles? The OS wouldn't allow you to create such
files in the first place. Maybe some checks when checking
out/updating/exporting. I don't know if a server can use a colon in a
filename today to write to your floppy drive:-)

I this this has been disucssed before. The main reason for to including
these checks is that they must be a project policy. If you have only
Windows developers, you won't have these filenames added. If you are a
mixed environment, the ones who need the check live on that OS that allow
these characters. I think this belongs in a pre-commit hook script.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 14 10:19:25 2004

This is an archived mail posted to the Subversion Dev mailing list.