[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Localization of user replies

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2004-12-05 21:45:36 CET

Norbert Unterberg <nepo@gmx.net> writes:

> const char *replies = _("RrTtPp"); /* allow l10n */
>
> ...
>
> svn_stringbuf_appendcstr
>
> (buf, _("(R)eject, accept (t)emporarily or accept (p)ermanently? "));
>
> ...
>
> SVN_ERR (prompt (&choice, buf->data, FALSE, ctx, pool));
>
> if (choice && (choice[0] == replies[2] || choice[0] == replies[3]))
>
> { ... }

I think it assumes that the replies are represented by single bytes.
While that may be acceptable for western languages does it apply to
things like Chinese? Hmm, our prompt code doesn't appear to handle
multiple byte replies either :(

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Dec 5 21:46:41 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.